From e91b3067a168f9729a9d4a353ff3e2ba83a473db Mon Sep 17 00:00:00 2001
From: Loren Burkholder <computersemiexpert@outlook.com>
Date: Mon, 19 Jul 2021 12:32:09 -0400
Subject: [PATCH] Fix visibility of spinner

---
 resources/qml/RoomMembers.qml | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/resources/qml/RoomMembers.qml b/resources/qml/RoomMembers.qml
index 28e999db..0d957165 100644
--- a/resources/qml/RoomMembers.qml
+++ b/resources/qml/RoomMembers.qml
@@ -114,12 +114,9 @@ ApplicationWindow {
                 }
 
                 footer: Spinner {
-                    // This is not a wonderful solution, but it is the best way to calculate whether
-                    // all users are loaded while keeping canFetchMore() const
-
-                    // TODO: just toggling the visiblity leaves some large empty space at the bottom
-                    // of the list. This should be fixed.
                     visible: members.numUsersLoaded < members.memberCount
+                    // use the default height if it's visible, otherwise no height at all
+                    height: visible ? undefined : 0
                     anchors.centerIn: parent
                 }
             }