From d5a6a46bc5db9ae2bc924becd148f6e3a5ba1c5c Mon Sep 17 00:00:00 2001
From: Nicolas Werner <nicolas.werner@hotmail.de>
Date: Sat, 23 Jul 2022 13:19:24 +0200
Subject: [PATCH] Pass context object to properly disconnect when this is
 deleted

---
 src/timeline/InputBar.cpp | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/timeline/InputBar.cpp b/src/timeline/InputBar.cpp
index 47efa867..4ac2708e 100644
--- a/src/timeline/InputBar.cpp
+++ b/src/timeline/InputBar.cpp
@@ -921,6 +921,7 @@ MediaUpload::MediaUpload(std::unique_ptr<QIODevice> source_,
                 });
         connect(mediaPlayer,
                 qOverload<const QString &, const QVariant &>(&QMediaPlayer::metaDataChanged),
+                this,
                 [this, mediaPlayer](QString t, QVariant) {
                     nhlog::ui()->debug("Got metadata {}", t.toStdString());
 
@@ -937,14 +938,15 @@ MediaUpload::MediaUpload(std::unique_ptr<QIODevice> source_,
                         }
                     }
                 });
-        connect(mediaPlayer, &QMediaPlayer::durationChanged, [this, mediaPlayer](qint64 duration) {
-            if (duration > 0) {
-                this->duration_ = mediaPlayer->duration();
-                if (mimeClass_ == u"audio")
-                    mediaPlayer->stop();
-            }
-            nhlog::ui()->debug("Duration changed {}", duration);
-        });
+        connect(
+          mediaPlayer, &QMediaPlayer::durationChanged, this, [this, mediaPlayer](qint64 duration) {
+              if (duration > 0) {
+                  this->duration_ = mediaPlayer->duration();
+                  if (mimeClass_ == u"audio")
+                      mediaPlayer->stop();
+              }
+              nhlog::ui()->debug("Duration changed {}", duration);
+          });
 
         auto originalFile = qobject_cast<QFile *>(source.get());