From cfaecaab17c07c7542b6502159f11622813ad01b Mon Sep 17 00:00:00 2001 From: Johannes Walcher Date: Tue, 10 Jul 2018 10:39:28 +0200 Subject: [PATCH] Limit -Wshadow to non-gcc (#368) --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 30e2cd18..7aa75a3e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -96,13 +96,17 @@ if(NOT MSVC) -Wall \ -Wextra \ -Werror \ - -Wshadow \ -pipe \ -pedantic \ -fsized-deallocation \ -fdiagnostics-color=always \ -Wunreachable-code" ) + if (NOT CMAKE_COMPILER_IS_GNUCXX) + # -Wshadow is buggy and broken in GCC, so do not enable it. + # see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79328 + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wshadow") + endif() endif() if(NOT (CMAKE_BUILD_TYPE OR CMAKE_CONFIGURATION_TYPES))