rnhmjoj
/
nheko
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Adjust scrollbar only after pagination (#94) 

The scrollbar will stay in the same position if new messages
are added to the bottom of the timeline.
This commit is contained in:
Konstantinos Sideris 2017-10-27 13:36:26 +03:00
parent c6e1068e0e
commit 8e15a5080d
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/TimelineView.h
View File

@ -155,6 +155,8 @@ private:
int oldPosition_;
int oldHeight_;
TimelineDirection lastMessageDirection_;
// The events currently rendered. Used for duplicate detection.
QMap<QString, bool> eventIds_;
QList<PendingMessage> pending_msgs_;

11
src/TimelineView.cc
View File

@ -96,7 +96,8 @@ TimelineView::sliderRangeChanged(int min, int max)
if (oldPosition_ == 0 && !scroll_area_->verticalScrollBar()->isVisible())
newPosition = max;
scroll_area_->verticalScrollBar()->setValue(newPosition);
if (lastMessageDirection_ == TimelineDirection::Top)
scroll_area_->verticalScrollBar()->setValue(newPosition);
}
void
@ -194,6 +195,8 @@ TimelineView::addBackwardsEvents(const QString &room_id, const RoomMessages &msg
for (const auto &item : items)
addTimelineItem(item, TimelineDirection::Top);
lastMessageDirection_ = TimelineDirection::Top;
QApplication::processEvents();
prev_batch_token_ = msgs.end();
@ -349,6 +352,8 @@ TimelineView::addEvents(const Timeline &timeline)
}
}
lastMessageDirection_ = TimelineDirection::Bottom;
QApplication::processEvents();
if (isInitialSync) {
@ -490,6 +495,8 @@ TimelineView::addUserMessage(matrix::events::MessageEventType ty, const QString
TimelineItem *view_item = new TimelineItem(ty, user_id, body, with_sender, scroll_widget_);
scroll_layout_->addWidget(view_item);
lastMessageDirection_ = TimelineDirection::Bottom;
QApplication::processEvents();
lastSender_ = user_id;
@ -510,6 +517,8 @@ TimelineView::addUserMessage(const QString &url, const QString &filename, int tx
TimelineItem *view_item = new TimelineItem(image, user_id, with_sender, scroll_widget_);
scroll_layout_->addWidget(view_item);
lastMessageDirection_ = TimelineDirection::Bottom;
QApplication::processEvents();
lastSender_ = user_id;