rnhmjoj
/
nheko
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use a better regex to identify URLs

This commit is contained in:
Konstantinos Sideris 2017-12-24 13:13:07 +02:00
parent 74ffef9826
commit 6835a97b15
4 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/Config.h
View File

@ -1,5 +1,8 @@
#pragma once
#include <QRegExp>
#include <QString>
// Non-theme app configuration. Layouts, fonts spacing etc.
//
// Font sizes are in pixels.
@ -16,6 +19,12 @@ namespace dialogs {
static constexpr int labelSize = 15;
}
namespace strings {
static const QString url_html = "<a href=\"\\1\">\\1</a>";
static const QRegExp url_regex(
"((www\\.(?!\\.)|[a-z][a-z0-9+.-]*://)[^\\s<>'\"]+[^!,\\.\\s<>'\"\\]\\)\\:])");
}
// Window geometry.
namespace window {
static constexpr int height = 600;

3
include/TopRoomBar.h
View File

@ -36,9 +36,6 @@ class Menu;
class OverlayModal;
class RoomSettings;
static const QString URL_HTML = "<a href=\"\\1\">\\1</a>";
static const QRegExp URL_REGEX("((?:https?|ftp)://\\S+)");
class TopRoomBar : public QWidget
{
Q_OBJECT

2
src/TopRoomBar.cc
View File

@ -216,7 +216,7 @@ TopRoomBar::paintEvent(QPaintEvent *event)
elidedText =
QFontMetrics(topicLabel_->font())
.elidedText(roomTopic_, Qt::ElideRight, topicLabel_->width() - perFrameResize);
elidedText.replace(URL_REGEX, URL_HTML);
elidedText.replace(conf::strings::url_regex, conf::strings::url_html);
topicLabel_->setText(elidedText);
}

12
src/timeline/TimelineItem.cc
View File

@ -16,7 +16,6 @@
*/
#include <QFontDatabase>
#include <QRegExp>
#include <QTextEdit>
#include "Avatar.h"
@ -28,9 +27,6 @@
#include "timeline/widgets/ImageItem.h"
#include "timeline/widgets/VideoItem.h"
static const QRegExp URL_REGEX("((?:https?|ftp)://\\S+)");
static const QString URL_HTML = "<a href=\"\\1\">\\1</a>";
void
TimelineItem::init()
{
@ -84,7 +80,7 @@ TimelineItem::TimelineItem(mtx::events::MessageType ty,
}
body = body.toHtmlEscaped();
body.replace(URL_REGEX, URL_HTML);
body.replace(conf::strings::url_regex, conf::strings::url_html);
body.replace("\n", "<br/>");
generateTimestamp(timestamp);
@ -206,7 +202,7 @@ TimelineItem::TimelineItem(const mtx::events::RoomEvent<mtx::events::msg::Notice
generateTimestamp(timestamp);
body.replace(URL_REGEX, URL_HTML);
body.replace(conf::strings::url_regex, conf::strings::url_html);
body.replace("\n", "<br/>");
body = "<i>" + body + "</i>";
@ -252,7 +248,7 @@ TimelineItem::TimelineItem(const mtx::events::RoomEvent<mtx::events::msg::Emote>
generateTimestamp(timestamp);
emoteMsg = emoteMsg.toHtmlEscaped();
emoteMsg.replace(URL_REGEX, URL_HTML);
emoteMsg.replace(conf::strings::url_regex, conf::strings::url_html);
emoteMsg.replace("\n", "<br/>");
if (with_sender) {
@ -295,7 +291,7 @@ TimelineItem::TimelineItem(const mtx::events::RoomEvent<mtx::events::msg::Text>
generateTimestamp(timestamp);
body = body.toHtmlEscaped();
body.replace(URL_REGEX, URL_HTML);
body.replace(conf::strings::url_regex, conf::strings::url_html);
body.replace("\n", "<br/>");
if (with_sender) {