From 02e388e542ccd137d2382d7eaae7bd12638e8db0 Mon Sep 17 00:00:00 2001 From: targetakhil Date: Sun, 14 Mar 2021 23:16:41 +0530 Subject: [PATCH 1/3] fix windows video bug --- resources/qml/delegates/PlayableMediaMessage.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/qml/delegates/PlayableMediaMessage.qml b/resources/qml/delegates/PlayableMediaMessage.qml index f871e492..52277895 100644 --- a/resources/qml/delegates/PlayableMediaMessage.qml +++ b/resources/qml/delegates/PlayableMediaMessage.qml @@ -185,7 +185,7 @@ Rectangle { target: TimelineManager.timeline onMediaCached: { if (mxcUrl == model.data.url) { - media.source = "file://" + cacheUrl; + media.source = cacheUrl; button.state = "stopped"; console.log("media loaded: " + mxcUrl + " at " + cacheUrl); } From 5614f705769992e89ef0477c6a0ae63c730c3318 Mon Sep 17 00:00:00 2001 From: targetakhil Date: Sun, 14 Mar 2021 23:32:24 +0530 Subject: [PATCH 2/3] Add faq section --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index a857a0a1..ee8c114e 100644 --- a/README.md +++ b/README.md @@ -114,6 +114,13 @@ with [homebrew](https://brew.sh/): ```sh brew install --cask nheko ``` +### FAQ + +## +**Q:** Why don't videos run for me on Windows? + +**A:** You're probably missing the required video codecs, download [K-Lite Codec Pack](https://codecguide.com/download_kl.htm). +## ### Build Requirements From a4b7966d21d40061bb02674d05d01bc443f4a7ab Mon Sep 17 00:00:00 2001 From: targetakhil Date: Mon, 15 Mar 2021 09:03:06 +0530 Subject: [PATCH 3/3] prepend file:// for linux and macos --- src/timeline/TimelineModel.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/timeline/TimelineModel.cpp b/src/timeline/TimelineModel.cpp index ddec7287..6134262e 100644 --- a/src/timeline/TimelineModel.cpp +++ b/src/timeline/TimelineModel.cpp @@ -1246,7 +1246,11 @@ TimelineModel::cacheMedia(QString eventId, std::function ca QDir().mkpath(filename.path()); if (filename.isReadable()) { +#if defined(Q_OS_WIN) emit mediaCached(mxcUrl, filename.filePath()); +#else + emit mediaCached(mxcUrl, "file://" + filename.filePath()); +#endif if (callback) { callback(filename.filePath()); } @@ -1288,7 +1292,11 @@ TimelineModel::cacheMedia(QString eventId, std::function ca nhlog::ui()->warn("Error while saving file to: {}", e.what()); } +#if defined(Q_OS_WIN) emit mediaCached(mxcUrl, filename.filePath()); +#else + emit mediaCached(mxcUrl, "file://" + filename.filePath()); +#endif }); }