From d7bdff27b03fbc94c81bbad29088a572727cff4f Mon Sep 17 00:00:00 2001 From: Jedi18 Date: Fri, 22 Jan 2021 10:46:31 +0530 Subject: [PATCH] Fix assert failure due to calling versionOk on a different thread --- src/LoginPage.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/LoginPage.cpp b/src/LoginPage.cpp index dba5ba51..ec9b856f 100644 --- a/src/LoginPage.cpp +++ b/src/LoginPage.cpp @@ -174,8 +174,9 @@ LoginPage::LoginPage(QWidget *parent) setLayout(top_layout_); - connect(this, &LoginPage::versionOkCb, this, &LoginPage::versionOk); - connect(this, &LoginPage::versionErrorCb, this, &LoginPage::versionError); + connect(this, &LoginPage::versionOkCb, this, &LoginPage::versionOk, Qt::QueuedConnection); + connect( + this, &LoginPage::versionErrorCb, this, &LoginPage::versionError, Qt::QueuedConnection); connect(back_button_, SIGNAL(clicked()), this, SLOT(onBackButtonClicked())); connect(login_button_, SIGNAL(clicked()), this, SLOT(onLoginButtonClicked())); @@ -322,7 +323,7 @@ LoginPage::checkHomeserverVersion() break; } } - emit versionOk(loginMethod_); + emit versionOkCb(loginMethod_); }); }); }