optionally use QQuickWidget and replace ColorOverlay -> colorImageProvider

CMakeLists.txt

@@ -69,7 +69,7 @@ include(LMDB)
 #
 # Discover Qt dependencies.
 #
-find_package(Qt5 COMPONENTS Core Widgets LinguistTools Concurrent Svg Multimedia Qml QuickControls2 REQUIRED)
+find_package(Qt5 COMPONENTS Core Widgets LinguistTools Concurrent Svg Multimedia Qml QuickControls2 QuickWidgets REQUIRED)
 find_package(Qt5QuickCompiler)
 find_package(Qt5DBus)
 
@@ -234,6 +234,7 @@ set(SRC_FILES
     src/MainWindow.cpp
     src/MatrixClient.cpp
     src/MxcImageProvider.cpp
+    src/ColorImageProvider.cpp
     src/QuickSwitcher.cpp
     src/Olm.cpp
     src/RegisterPage.cpp
@@ -414,6 +415,7 @@ set(COMMON_LIBS
     Qt5::Multimedia
     Qt5::Qml
     Qt5::QuickControls2
+    Qt5::QuickWidgets
     nlohmann_json::nlohmann_json)
 
 if(APPVEYOR_BUILD)

resources/qml/EncryptionIndicator.qml

@@ -1,6 +1,5 @@
 import QtQuick 2.5
 import QtQuick.Controls 2.1
-import QtGraphicalEffects 1.0
 import com.github.nheko 1.0
 
 Rectangle {
@@ -19,12 +18,7 @@ Rectangle {
 	Image {
 		id: stateImg
 		anchors.fill: parent
-		source: "qrc:/icons/icons/ui/lock.png"
+		source: "image://colorimage/:/icons/icons/ui/lock.png?"+colors.buttonText
-	}
-	ColorOverlay {
-		anchors.fill: stateImg
-		source: stateImg
-		color: colors.buttonText
 	}
 }
 

resources/qml/ImageButton.qml

@@ -1,9 +1,8 @@
 import QtQuick 2.3
 import QtQuick.Controls 2.3
-import QtGraphicalEffects 1.0
 
 Button {
-	property alias image: buttonImg.source
+	property string image: undefined
 
 	id: button
 
@@ -17,11 +16,7 @@ Button {
 		id: buttonImg
 		// Workaround, can't get icon.source working for now...
 		anchors.fill: parent
-	}
+		source: "image://colorimage/" + image + "?" + (button.hovered ? colors.highlight : colors.buttonText)
-	ColorOverlay {
-		anchors.fill: buttonImg
-		source: buttonImg
-		color: button.hovered ? colors.highlight : colors.buttonText
 	}
 
 	MouseArea

resources/qml/StatusIndicator.qml

@@ -1,6 +1,5 @@
 import QtQuick 2.5
 import QtQuick.Controls 2.1
-import QtGraphicalEffects 1.0
 import com.github.nheko 1.0
 
 Rectangle {
@@ -28,18 +27,12 @@ Rectangle {
 		// Workaround, can't get icon.source working for now...
 		anchors.fill: parent
 		source: switch (indicator.state) {
-			case MtxEvent.Failed: return "qrc:/icons/icons/ui/remove-symbol.png"
+			case MtxEvent.Failed: return "image://colorimage/:/icons/icons/ui/remove-symbol.png?" + colors.buttonText
-			case MtxEvent.Sent: return "qrc:/icons/icons/ui/clock.png"
+			case MtxEvent.Sent: return "image://colorimage/:/icons/icons/ui/clock.png?" + colors.buttonText
-			case MtxEvent.Received: return "qrc:/icons/icons/ui/checkmark.png"
+			case MtxEvent.Received: return "image://colorimage/:/icons/icons/ui/checkmark.png?" + colors.buttonText
-			case MtxEvent.Read: return "qrc:/icons/icons/ui/double-tick-indicator.png"
+			case MtxEvent.Read: return "image://colorimage/:/icons/icons/ui/double-tick-indicator.png?" + colors.buttonText
 			default: return ""
 		}
 	}
-	ColorOverlay {
-		anchors.fill: stateImg
-		source: stateImg
-		color: colors.buttonText
-		visible: stateImg.source != ""
-	}
 }
 

resources/qml/TimelineRow.qml

@@ -50,7 +50,7 @@ RowLayout {
 		Layout.preferredHeight: 16
 		id: replyButton
 
-		image: "qrc:/icons/icons/ui/mail-reply.png"
+		image: ":/icons/icons/ui/mail-reply.png"
 		ToolTip {
 			visible: replyButton.hovered
 			text: qsTr("Reply")
@@ -64,7 +64,7 @@ RowLayout {
 		Layout.preferredHeight: 16
 		id: optionsButton
 
-		image: "qrc:/icons/icons/ui/vertical-ellipsis.png"
+		image: ":/icons/icons/ui/vertical-ellipsis.png"
 		ToolTip {
 			visible: optionsButton.hovered
 			text: qsTr("Options")

resources/qml/TimelineView.qml

@@ -8,14 +8,14 @@ import com.github.nheko 1.0
 
 import "./delegates"
 
-Rectangle {
+Item {
-	anchors.fill: parent
-
 	property var colors: currentActivePalette
 	property var systemInactive: SystemPalette { colorGroup: SystemPalette.Disabled }
 	property var inactiveColors: currentInactivePalette ? currentInactivePalette : systemInactive
 	property int avatarSize: 40
 
+	Rectangle {
+		anchors.fill: parent
 		color: colors.window
 
 		Text {
@@ -48,9 +48,9 @@ Rectangle {
 						positionViewAtIndex(model.currentIndex, ListView.End)
 					}
 
-				if (contentHeight < height) {
+					//if (contentHeight < height) {
-					model.fetchHistory();
+					//	model.fetchHistory();
-				}
+					//}
 				}
 			}
 
@@ -64,7 +64,7 @@ Rectangle {
 
 			property bool atBottom: false
 			onCountChanged: {
-			if (atBottom && Window.active) {
+				if (atBottom) {
 					var newIndex = count - 1 // last index
 					positionViewAtEnd()
 					currentIndex = newIndex
@@ -79,14 +79,13 @@ Rectangle {
 			onAtYBeginningChanged: if (atYBeginning) model.fetchHistory()
 
 			function updatePosition() {
-			for (var y = chat.contentY + chat.height; y > chat.height; y -= 5) {
+				for (var y = chat.contentY + chat.height; y > chat.height; y -= 9) {
 					var i = chat.itemAt(100, y);
 					if (!i) continue;
 					if (!i.isFullyVisible()) continue;
 					chat.model.currentIndex = i.getIndex();
 					chat.currentIndex = i.getIndex()
 					atBottom = i.getIndex() == count - 1;
-				console.log("bottom:" + atBottom)
 					break;
 				}
 			}
@@ -159,4 +158,5 @@ Rectangle {
 				}
 			}
 		}
+	}
 }

src/ColorImageProvider.cpp

@@ -0,0 +1,30 @@
+#include "ColorImageProvider.h"
+
+#include "Logging.h"
+#include <QPainter>
+
+QPixmap
+ColorImageProvider::requestPixmap(const QString &id, QSize *size, const QSize &)
+{
+        auto args = id.split('?');
+
+        nhlog::ui()->info("Loading {}, source is {}", id.toStdString(), args[0].toStdString());
+
+        QPixmap source(args[0]);
+
+        if (size)
+                *size = QSize(source.width(), source.height());
+
+        if (args.size() < 2)
+                return source;
+
+        QColor color(args[1]);
+
+        QPixmap colorized = source;
+        QPainter painter(&colorized);
+        painter.setCompositionMode(QPainter::CompositionMode_SourceIn);
+        painter.fillRect(colorized.rect(), color);
+        painter.end();
+
+        return colorized;
+}

src/ColorImageProvider.h

@@ -0,0 +1,11 @@
+#include <QQuickImageProvider>
+
+class ColorImageProvider : public QQuickImageProvider
+{
+public:
+        ColorImageProvider()
+          : QQuickImageProvider(QQuickImageProvider::Pixmap)
+        {}
+
+        QPixmap requestPixmap(const QString &id, QSize *size, const QSize &requestedSize) override;
+};

src/timeline2/DelegateChooser.cpp

@@ -119,7 +119,6 @@ DelegateChooser::DelegateIncubator::statusChanged(QQmlIncubator::Status status)
                 chooser.child = dynamic_cast<QQuickItem *>(object());
                 if (chooser.child == nullptr) {
                         nhlog::ui()->error("Delegate has to be derived of Item!");
-                        delete chooser.child;
                         return;
                 }
 

src/timeline2/TimelineViewManager.cpp

@@ -8,6 +8,7 @@
 #include <QStandardPaths>
 
 #include "ChatPage.h"
+#include "ColorImageProvider.h"
 #include "DelegateChooser.h"
 #include "Logging.h"
 #include "MxcImageProvider.h"
@@ -51,6 +52,7 @@ TimelineViewManager::updateColorPalette()
 
 TimelineViewManager::TimelineViewManager(QWidget *parent)
   : imgProvider(new MxcImageProvider())
+  , colorImgProvider(new ColorImageProvider())
 {
         qmlRegisterUncreatableMetaObject(qml_mtx_events::staticMetaObject,
                                          "com.github.nheko",
@@ -61,12 +63,24 @@ TimelineViewManager::TimelineViewManager(QWidget *parent)
         qmlRegisterType<DelegateChoice>("com.github.nheko", 1, 0, "DelegateChoice");
         qmlRegisterType<DelegateChooser>("com.github.nheko", 1, 0, "DelegateChooser");
 
+#ifdef USE_QUICK_VIEW
         view      = new QQuickView();
         container = QWidget::createWindowContainer(view, parent);
+#else
+        view      = new QQuickWidget(parent);
+        container = view;
+        view->setResizeMode(QQuickWidget::SizeRootObjectToView);
+        container->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+
+        connect(view, &QQuickWidget::statusChanged, this, [](QQuickWidget::Status status) {
+                nhlog::ui()->debug("Status changed to {}", status);
+        });
+#endif
         container->setMinimumSize(200, 200);
         view->rootContext()->setContextProperty("timelineManager", this);
         updateColorPalette();
         view->engine()->addImageProvider("MxcImage", imgProvider);
+        view->engine()->addImageProvider("colorimage", colorImgProvider);
         view->setSource(QUrl("qrc:///qml/TimelineView.qml"));
 
         connect(dynamic_cast<ChatPage *>(parent),

src/timeline2/TimelineViewManager.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <QQuickView>
+#include <QQuickWidget>
 #include <QSharedPointer>
 #include <QWidget>
 
@@ -16,6 +17,7 @@
 #pragma GCC diagnostic ignored "-Wunused-parameter"
 
 class MxcImageProvider;
+class ColorImageProvider;
 
 class TimelineViewManager : public QObject
 {
@@ -99,10 +101,15 @@ public slots:
                                uint64_t dsize);
 
 private:
+#ifdef USE_QUICK_VIEW
         QQuickView *view;
+#else
+        QQuickWidget *view;
+#endif
         QWidget *container;
         TimelineModel *timeline_ = nullptr;
         MxcImageProvider *imgProvider;
+        ColorImageProvider *colorImgProvider;
 
         QHash<QString, QSharedPointer<TimelineModel>> models;
 };