From 1024198228692d2b6b56b6a7b15df4890c1c298e Mon Sep 17 00:00:00 2001 From: Konstantinos Sideris Date: Fri, 22 Sep 2017 21:34:31 +0300 Subject: [PATCH] Fix reverse iterator crash --- src/TimelineView.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/TimelineView.cc b/src/TimelineView.cc index 600ccb94..cffc8601 100644 --- a/src/TimelineView.cc +++ b/src/TimelineView.cc @@ -167,11 +167,12 @@ TimelineView::addBackwardsEvents(const QString &room_id, const RoomMessages &msg // Parse in reverse order to determine where we should not show sender's // name. - auto it = msgs.chunk().constEnd(); - while (it != msgs.chunk().constBegin()) { - --it; + auto ii = msgs.chunk().size(); + while (ii != 0) { + --ii; - TimelineItem *item = parseMessageEvent((*it).toObject(), TimelineDirection::Top); + TimelineItem *item = + parseMessageEvent(msgs.chunk().at(ii).toObject(), TimelineDirection::Top); if (item != nullptr) items.push_back(item);